ESP32Async/ESPAsyncWebServer @ 3.9.2 #2905
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR upgrades the ESPAsyncWebServer library from version 3.8.0 to 3.9.2 and AsyncTCP from 3.4.7 to 3.4.9, along with necessary code adaptations to maintain compatibility with the new library version.
Key changes:
- Updated ESPAsyncWebServer dependency from 3.8.0 to 3.9.2
- Updated AsyncTCP dependency from 3.4.7 to 3.4.9
- Added explicit
static_cast<ArRequestHandlerFunction>wrapper around allstd::bindcalls for single-parameter request handlers to satisfy new library type requirements
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| platformio.ini | Updated ESPAsyncWebServer to 3.9.2 and AsyncTCP to 3.4.9 |
| src/WebApi_ws_live.cpp | Added static_cast wrapper for request handler registration |
| src/WebApi_sysstatus.cpp | Added static_cast wrapper for request handler registration |
| src/WebApi_security.cpp | Added static_cast wrapper for three request handler registrations |
| src/WebApi_prometheus.cpp | Added static_cast wrapper for request handler registration |
| src/WebApi_power.cpp | Added static_cast wrapper for two request handler registrations |
| src/WebApi_ntp.cpp | Added static_cast wrapper for five request handler registrations |
| src/WebApi_network.cpp | Added static_cast wrapper for three request handler registrations |
| src/WebApi_mqtt.cpp | Added static_cast wrapper for three request handler registrations |
| src/WebApi_maintenance.cpp | Added static_cast wrapper for request handler registration |
| src/WebApi_logging.cpp | Added static_cast wrapper for two request handler registrations |
| src/WebApi_limit.cpp | Added static_cast wrapper for two request handler registrations |
| src/WebApi_inverter.cpp | Added static_cast wrapper for six request handler registrations |
| src/WebApi_i18n.cpp | Added static_cast wrapper for two request handler registrations |
| src/WebApi_gridprofile.cpp | Added static_cast wrapper for two request handler registrations |
| src/WebApi_file.cpp | Added static_cast wrapper for four request handler registrations |
| src/WebApi_eventlog.cpp | Added static_cast wrapper for request handler registration |
| src/WebApi_dtu.cpp | Added static_cast wrapper for two request handler registrations |
| src/WebApi_devinfo.cpp | Added static_cast wrapper for request handler registration |
| src/WebApi_device.cpp | Added static_cast wrapper for two request handler registrations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade PR for ESP32Async/ESPAsyncWebServer @ 3.9.2