Skip to content

Fix tailing logs stops working after sometimes #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2020

Conversation

anhpt379
Copy link

prometheus-nginx-log-exporter stopped tailing logs on many of my servers
after sometimes and needed a manual restart to start working again.

I couldn't able to reproduce it, but as suggested here,
switching from inotify (default) to poll might help to fix the issue.

Also in a similar nginx log exporter, they're using Poll: true as well.

@anhpt379
Copy link
Author

I found out that this issue was fixed in hpcloud/tail#99, but the hpcloud/tail version we're using (v1.0.0 - the latest release) doesn't have that commit yet

@anhpt379
Copy link
Author

anhpt379 commented May 19, 2020

Updated the PR with updating hpcloud/tail version only

@tdevelioglu
Copy link
Owner

Hi Anh, lgtm. Could you also mention in the commit message why the change to fsnotify was made ?

Mainly to include this change: hpcloud/tail#99

I also ran `go mod tidy` to update indirect dependency (fsnotify)
@anhpt379
Copy link
Author

just updated as requested. fsnotify was changed because I ran go mod tidy to update indirect dependencies

@anhpt379 anhpt379 changed the title Fix tailing logs stops working sometimes Fix tailing logs stops working after sometimes May 20, 2020
@tdevelioglu tdevelioglu merged commit 494b75c into tdevelioglu:master May 20, 2020
@tdevelioglu
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants