-
Notifications
You must be signed in to change notification settings - Fork 1
Invalidate dependent elements #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jan888adams
wants to merge
40
commits into
main
Choose a base branch
from
invalidate-dependent-elements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 24 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
cd296b3
Invalidate dependent elements
jan888adams 70c0a27
Refactor test factories
jan888adams c0ede1b
Add testcases for asset & document invalidation
jan888adams b3161a4
Only invalidate dependencies from objects
jan888adams 2656151
Test invalidation for dependent documents
jan888adams 365cd1a
Fix review findings: final class, and negative dependency traversal t…
0968867
Revert ElementRepository to non-final class (required for Prophecy mo…
dbbf303
Remove asset case from dependency invalidation — assets cannot refere…
7a02f80
Restore asset case in dependency invalidation
3ffcd0f
Make dependency traversal configurable, disabled by default
ba1c99d
Fix review findings: int cast, test naming, wrong import, missing tests
b3b418e
Document invalidate_dependencies configuration
c35ca2f
Fix review findings: extract shared traversal method, clarify docs
f25af37
Honor cancellation before dependency traversal
36b225c
Fix type mismatch in dependency traversal: use tryFromElement()
e022faa
Run save() inside arrange() closure
d2aa5c1
Fix assertion: check additional tag o12, not primary tag o5
c0591a4
Fix mismatched hardlink tag assertion: check d12, not d29
dacd82e
Move configKey() from InvalidateElementListener to ElementType enum
2438a32
Extract shouldSkipInvalidation() into a private method
f5f0256
Introduce ElementsConfig as a compile-time config value object
dc7ac15
Address review findings: document traversal depth and cover missing c…
b434ec9
Extract DependencyInvalidator class from InvalidateElementListener
00f70ab
Address review findings: fix callable PHPDoc and add missing tests
778c512
Form a domain around 'dependent element'
4e6b8a2
Address review findings: final ElementsConfig and missing source-type…
eab4a09
Rename DependentElementInvalidator to DependentElementFinder
15675d1
Fix docs: update config key from invalidate_dependencies to invalidat…
d2e0b39
Honor element subtype and class config in DependentElementFinder
53897b2
Add fine-grained subtype/class config for dependent element invalidation
b6c11fe
Address review findings: add fine-grained config docs and two-layer f…
f387e7e
Move array @param annotations inline on promoted constructor params
26a1284
Refactor: move element checks into ElementsConfig, clean up naming
02e6e08
Add fine-grained subtype/class config example to configuration overview
38a85c3
Add missing tests and fix pre-existing factory/naming issues
b30e6e9
Address review findings: clean up services placeholder and add positi…
79cdf3b
Apply PHP CS Fixer style fixes
62d8756
Fix phpstan errors, test assertions and pre-filter optimization
09b29b1
Fix pre-existing test bugs exposed after removing merge commit
3d7e9aa
Remove unused source element getType() mocks from DependentElementFin…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think element types alone might not be sufficient. We should probably consider subtypes as well.