go: go.mod file not found in current directory or any parent directory

[rleighton]

I get:

go: go.mod file not found in current directory or any parent directory

However:

bash-3.2$ ls go.mod
go.mod

The command:

xgo -x --deps https://www.sqlite.org/2020/sqlite-autoconf-3320300.tar.gz --depsargs '--disable-fts4 --disable-fts5 --disable-rtree --disable-static-shell' --pkg internal/log_analysis/datalake/database_api/snowflake/driver/main --targets=linux/amd64 -out main --tags 'libsqlite3 linux' -dest out/bin/internal/log_analysis/datalake/database_api/snowflake/driver/main .

Any ideas?

This worked with go 1.13 but now I have to move to 1.16 because of other changes in the code base.

[techknowlogick]

Do you have an example repo that I could try this on?

[rleighton]

I don't but thanks for asking. If I can't sort this maybe I can craft one.

I'm wondering if it is related to any of this new 1.16 changes: https://blog.golang.org/go116-module-changes.

Interestingly, if I run with -go go-1.15.10 it works BUT my application uses the new 1.16 embed feature and so it fails build.

[rleighton]

Found the issue , tiny PR coming. The change is specific to a local build.

[rleighton]

The issue is resetting config.Repository before the test for go.mod.

I don't have permissions to post a PR. This is the diff:

commit 66c5a7348e45f209e851114ae735bd53f37f1ec6 (HEAD -> russ-fix-local-module-builds)
Author: Russell Leighton <russell.leighton@runpanther.io>
Date:   Sat Mar 20 07:10:31 2021 -0400

    Fix repo path setting bug for local builds

diff --git a/xgo.go b/xgo.go
index a341db0..961ecaf 100644
--- a/xgo.go
+++ b/xgo.go
@@ -255,19 +255,19 @@ func compile(image string, config *ConfigFlags, flags *BuildFlags, folder string
        locals, mounts, paths := []string{}, []string{}, []string{}
        var usesModules bool
        if strings.HasPrefix(config.Repository, string(filepath.Separator)) || strings.HasPrefix(config.Repository, ".") {
-               // Resolve the repository import path from the file path
-               config.Repository = resolveImportPath(config.Repository)
-
                // Determine if this is a module-based repository
-               var modFile = config.Repository + "/go.mod"
-               _, err := os.Stat(modFile)
-               usesModules = !os.IsNotExist(err)
+               if _, err := os.Stat(config.Repository + "/go.mod"); err == nil {
+                       usesModules = true
+               }
 
                // Iterate over all the local libs and export the mount points
                if os.Getenv("GOPATH") == "" && !usesModules {
                        log.Fatalf("No $GOPATH is set or forwarded to xgo")
                }
                if !usesModules {
+                       // Resolve the repository import path from the file path
+                       config.Repository = resolveImportPath(config.Repository)
+
                        for _, gopath := range strings.Split(os.Getenv("GOPATH"), string(os.PathListSeparator)) {
                                // Since docker sandboxes volumes, resolve any symlinks manually
                                sources := filepath.Join(gopath, "src")

[rleighton]

I don't but thanks for asking. If I can't sort this maybe I can craft one.

I'm wondering if it is related to any of this new 1.16 changes: https://blog.golang.org/go116-module-changes.

Interestingly, if I run with -go go-1.15.10 it works BUT my application uses the new 1.16 embed feature and so it fails build.

1.15 worked because I had GOPATH set.

[techknowlogick]

Awesome, thanks :) Let me try to put this together as a PR.

[rleighton]

Do have an idea when this might merge? We have obviously a working forked version but it would make our builds easier when this is updated. Thank you !

[serbantanasa]

Hi @techknowlogick @rleighton I've hit this issue too -- seems to be a 6 line fix. I'd push a PR but don't have the permissions.

Here's a git patch:

From b81da5dd77c6d0934d7a79064a6c287bba6f0ee9 Mon Sep 17 00:00:00 2001
From: serbantanasa <serban.tanasa@xxxxx.xx>
Date: Tue, 23 Mar 2021 12:56:04 -0400
Subject: [PATCH] fix xgo issue
​
---
 xgo.go | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)
​
diff --git a/xgo.go b/xgo.go
index a341db0..a6f46bc 100644
--- a/xgo.go
+++ b/xgo.go
@@ -255,19 +255,18 @@ func compile(image string, config *ConfigFlags, flags *BuildFlags, folder string
 	locals, mounts, paths := []string{}, []string{}, []string{}
 	var usesModules bool
 	if strings.HasPrefix(config.Repository, string(filepath.Separator)) || strings.HasPrefix(config.Repository, ".") {
-		// Resolve the repository import path from the file path
-		config.Repository = resolveImportPath(config.Repository)
-
-		// Determine if this is a module-based repository
-		var modFile = config.Repository + "/go.mod"
-		_, err := os.Stat(modFile)
-		usesModules = !os.IsNotExist(err)
+		if _, err := os.Stat(config.Repository + "/go.mod"); err == nil {
+			usesModules = true
+		}
 
 		// Iterate over all the local libs and export the mount points
 		if os.Getenv("GOPATH") == "" && !usesModules {
 			log.Fatalf("No $GOPATH is set or forwarded to xgo")
 		}
 		if !usesModules {
+			// Resolve the repository import path from the file path
+			config.Repository = resolveImportPath(config.Repository)
+
 			for _, gopath := range strings.Split(os.Getenv("GOPATH"), string(os.PathListSeparator)) {
 				// Since docker sandboxes volumes, resolve any symlinks manually
 				sources := filepath.Join(gopath, "src")
-- 
2.24.3 (Apple Git-128)
​

[serbantanasa]

any news?

[rleighton]

@techknowlogick ping?

[thebaer]

I'm seeing same issue in our WriteFreely project... Running this command produces the same error, despite there being a go.mod file in the current directory where this is being run from:

xgo --targets=linux/amd64, -dest build/ -tags='sqlite' -out writefreely ./cmd/writefreely

Not sure if we need to change the command, or if this is a bug in xgo, but this used to work.

[makew0rld]

@thebaer It's a bug in xgo. You can use the patch above, or just run xgo with go1.15 instead of 1.16.

[thebaer]

Thanks! Adding -go go-1.15.x fixed this for me.