Use build.Default.GOPATH instead of os.Env("GOPATH") in modules #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using modules it is not guaranteed that GOPATH will be set, instead use the build.Default.GOPATH which will be overriden by os.Env when GOPATH is set, but will still be a reasonable path if not. Signed-off-by: Andrew Thornton <[email protected]>
|
It may also be worth considering changing the other places that use os.Env("GOPATH") to use this instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using modules it is not guaranteed that GOPATH will be set, instead
use the build.Default.GOPATH which will be overriden by os.Env when
GOPATH is set, but will still be a reasonable path if not.
Signed-off-by: Andrew Thornton [email protected]