Skip to content

Properly quote the GCFLAGS and LDFLAGS #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2022
Merged

Properly quote the GCFLAGS and LDFLAGS #186

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e14dd88
Properly quote the GCFLAGS and LDFLAGS
zeripath Nov 23, 2022
6ff156b
as per xoxys
zeripath Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docker/base/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ if [ "$FLAG_X" == "true" ]; then X=-x; fi
if [ "$FLAG_RACE" == "true" ]; then R=-race; fi
if [ "$FLAG_TAGS" != "" ]; then T=(--tags "$FLAG_TAGS"); fi
if [ "$FLAG_LDFLAGS" != "" ]; then LD=("${LD[@]}" "${FLAG_LDFLAGS[@]}"); fi
if [ "$FLAG_GCFLAGS" != "" ]; then GC=(--gcflags="$FLAG_GCFLAGS"); fi
if [ "$FLAG_GCFLAGS" != "" ]; then GC=(--gcflags="$(printf "%s " "${FLAG_GCFLAGS[@]}")"); fi

if [ "$FLAG_BUILDMODE" != "" ] && [ "$FLAG_BUILDMODE" != "default" ]; then BM=(--buildmode="${FLAG_BUILDMODE[@]}"); fi
if [ "$FLAG_TRIMPATH" == "true" ]; then TP=-trimpath; fi
Expand All @@ -193,7 +193,7 @@ if [ "$TARGETS" == "" ]; then
TARGETS="./."
fi

if [ "${#LD[@]}" -gt 0 ]; then LDF=(--ldflags="${LD[@]}"); fi
if [ "${#LD[@]}" -gt 0 ]; then LDF=(--ldflags="$(printf "%s " "${LD[@]}")"); fi

# Build for each requested platform individually
for TARGET in $TARGETS; do
Expand Down Expand Up @@ -439,7 +439,7 @@ for TARGET in $TARGETS; do
LDS=("-s" "${LDS[@]}")
fi
if [ ${#LDS[@]} -gt 0 ]; then
LDFS=(--ldflags="${LDS[@]}")
LDFS=(--ldflags="$(printf "%s " "${LD[@]}")")
fi
# Build the requested darwin binaries
if [ "$XGOARCH" == "." ] || [ "$XGOARCH" == "amd64" ]; then
Expand Down