Added option to obfuscate builds using garble #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techknowlogick
requested changes
Apr 25, 2023
docker/build/Dockerfile
Outdated
| @@ -23,6 +23,12 @@ RUN \ | |||
|
|
|||
| WORKDIR / | |||
|
|
|||
| # Install garble for obfuscated builds | |||
| RUN \ | |||
There was a problem hiding this comment.
Thanks for this PR! Could you move this go install to toolchain/bootstrap_pure.sh, probably next to the line: echo "Bootstrapping is no longer needed for go 1.20+" is best. As garble states that go1.20 is required, this means that garble only is installed for go1.20+ You may also wish to add some conditional in xgo.go so that the flags are only accepted for the specific go versions.
There was a problem hiding this comment.
Good call, I can do that
…to xgo.go and build.sh
techknowlogick
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have any CGO-dependent packages to test this out on, but at least on pure Go code this works.