Skip to content

Cleanup a11y and TS warnings/errors #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Jun 23, 2024
Merged

Cleanup a11y and TS warnings/errors #409

merged 32 commits into from
Jun 23, 2024

Conversation

techniq
Copy link
Owner

@techniq techniq commented Jun 23, 2024

pnpm check --no-tsconfig --ignore "dist,src/routes"

Before After
image image

pnpm check

Before After
image image

Copy link

vercel bot commented Jun 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-ux ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2024 9:03pm

Copy link

changeset-bot bot commented Jun 23, 2024

🦋 Changeset detected

Latest commit: 0dfe413

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-ux Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

cloudflare-workers-and-pages bot commented Jun 23, 2024

Deploying svelte-ux with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0dfe413
Status: ✅  Deploy successful!
Preview URL: https://9ff82243.svelte-ux.pages.dev
Branch Preview URL: https://warning-cleanup.svelte-ux.pages.dev

View logs

@techniq
Copy link
Owner Author

techniq commented Jun 23, 2024

Focusing on lib-only initially (ignoring doc routes)

pnpm check --no-tsconfig --ignore "dist,src/routes"

Before After
image image

But still making progress overall

pnpm check

Before After
image image

@techniq
Copy link
Owner Author

techniq commented Jun 23, 2024

and then there was 1...

image

@techniq
Copy link
Owner Author

techniq commented Jun 23, 2024

zoolander-will-ferrell

image

image

@techniq techniq merged commit a32f3f5 into main Jun 23, 2024
5 checks passed
@techniq techniq deleted the warning-cleanup branch June 23, 2024 21:06
@github-actions github-actions bot mentioned this pull request Jun 23, 2024
@ttytm
Copy link
Contributor

ttytm commented Jun 25, 2024

Thanks for the work 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants