Skip to content

Feat(data): add regex match utility function snippet in JS #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

aumirza
Copy link
Contributor

@aumirza aumirza commented Dec 30, 2024

No description provided.

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for quicksnip ready!

Name Link
🔨 Latest commit 4a7484b
🔍 Latest deploy log https://app.netlify.com/sites/quicksnip/deploys/6772dc5ee41dee00084d5a53
😎 Deploy Preview https://deploy-preview-38--quicksnip.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@Mathys-Gasnier Mathys-Gasnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add indentation to your example, it's very hard to read and understand at the moment

@technoph1le
Copy link
Owner

Hey, there! Thanks for the contribution. I also agree that you should fix the indentation in your code.


An idea for Issue #41 was inspired by this pull request. It becomes much difficult for maintainers to review the code when there's no description in the pull request.

@technoph1le technoph1le added the update needed Code needs to be updated. label Dec 30, 2024
@aumirza
Copy link
Contributor Author

aumirza commented Dec 30, 2024

Please add indentation to your example, it's very hard to read and understand at the moment

Yeah, I noticed it later. Will fix it.

@Mathys-Gasnier
Copy link
Collaborator

Hey, we recently updated how snippets are stored, please update your PR to match the changes, you will be able to see how to add snippets in CONTRIBUTING.md.
For ref: #87

@Mathys-Gasnier
Copy link
Collaborator

Hey, changes were requested on your PR, but we got no news for more than a week, Closing this as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Snippets update needed Code needs to be updated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants