Skip to content

Conversation

@Emantor
Copy link
Contributor

@Emantor Emantor commented Jan 3, 2021

Fix the following DeprecationWarnings:

  =============================== warnings summary ===============================
  test/functional/test_failures.py::test_xmodem_recv_bad_checksum
    /nix/store/wjqnk8fmd71y77l19fcnzlpkpz5a6h3r-python3.6-xmodem-0.4.6/lib/python3.6/site-packages/xmodem/__init__.py:579: DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead
      their_sum, our_sum)

  test/functional/test_failures.py::test_xmodem_recv_bad_checksum
    /nix/store/wjqnk8fmd71y77l19fcnzlpkpz5a6h3r-python3.6-xmodem-0.4.6/lib/python3.6/site-packages/xmodem/__init__.py:550: DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead
      self.log.warn('recv error: purge, requesting retransmission (NAK)')

  test/unit/test_xmodem.py::test_xmodem_send_exceed_maximum_number_of_resend[stream_data0-xmodem1k]
    /nix/store/wjqnk8fmd71y77l19fcnzlpkpz5a6h3r-python3.6-xmodem-0.4.6/lib/python3.6/site-packages/xmodem/__init__.py:359: DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead
      self.log.warn('EOT was not ACKd, aborting transfer')

  -- Docs: https://docs.pytest.org/en/stable/warnings.html
  ======================== 19 passed, 3 warnings in 4.21s ========================

by using the warning function.

Fix the following DeprecationWarnings:

  =============================== warnings summary ===============================
  test/functional/test_failures.py::test_xmodem_recv_bad_checksum
    /nix/store/wjqnk8fmd71y77l19fcnzlpkpz5a6h3r-python3.6-xmodem-0.4.6/lib/python3.6/site-packages/xmodem/__init__.py:579: DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead
      their_sum, our_sum)

  test/functional/test_failures.py::test_xmodem_recv_bad_checksum
    /nix/store/wjqnk8fmd71y77l19fcnzlpkpz5a6h3r-python3.6-xmodem-0.4.6/lib/python3.6/site-packages/xmodem/__init__.py:550: DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead
      self.log.warn('recv error: purge, requesting retransmission (NAK)')

  test/unit/test_xmodem.py::test_xmodem_send_exceed_maximum_number_of_resend[stream_data0-xmodem1k]
    /nix/store/wjqnk8fmd71y77l19fcnzlpkpz5a6h3r-python3.6-xmodem-0.4.6/lib/python3.6/site-packages/xmodem/__init__.py:359: DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead
      self.log.warn('EOT was not ACKd, aborting transfer')

  -- Docs: https://docs.pytest.org/en/stable/warnings.html
  ======================== 19 passed, 3 warnings in 4.21s ========================

by using the warning function.
@coveralls
Copy link

Coverage Status

Coverage increased (+58.0%) to 57.967% when pulling 318896c on Emantor:fix/deprecation into 435661b on tehmaze:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+58.0%) to 57.967% when pulling 318896c on Emantor:fix/deprecation into 435661b on tehmaze:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+58.0%) to 57.967% when pulling 318896c on Emantor:fix/deprecation into 435661b on tehmaze:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+58.0%) to 57.967% when pulling 318896c on Emantor:fix/deprecation into 435661b on tehmaze:master.

@tehmaze tehmaze merged commit a9d8514 into tehmaze:master Jan 3, 2021
@tehmaze
Copy link
Owner

tehmaze commented Jan 3, 2021

Thanks.

@Emantor Emantor deleted the fix/deprecation branch January 3, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants