Fixed getc timeout handling #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…next packet header, the retry loop was not receiving next character thus rechecking the same value until aborting. With this change, a next character will be retrieved when retrying
jquast
approved these changes
Mar 29, 2023
Collaborator
jquast
left a comment
jquast
left a comment
There was a problem hiding this comment.
nice fix, thanks for test and version bump, I'll try to release this shortly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In recv method, when timeout occurs during reading of first byte of next packet header, the retry loop was not receiving next character thus rechecking the same value until aborting. With this change, a next character will be retrieved when retrying.