Migrate CI into GitHub workflows #2516

vdemeester · 2025-03-13T14:33:48Z

Changes

.github/workflows: update codeql job
.github/workflows: add slack and retest workflows
.github/workflows: add a ci workflow…

Closes #2452

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Run the code checkers with make check
Regenerate the manpages, docs and go formatting with make generated
Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

NONE

waveywaves · 2025-03-13T16:45:34Z

/retest

vdemeester · 2025-03-13T17:17:02Z

We can ignore pull-tekton-cli-build-tests, it will be removed 👼🏼

.github/workflows/chatops_retest.yaml

With tektoncd/cli#2516 those are no more needed. Signed-off-by: Vincent Demeester <[email protected]>

vdemeester · 2025-03-17T10:48:16Z

/retest

vdemeester · 2025-03-17T12:00:27Z

/retest

aThorp96 · 2025-03-21T12:05:18Z

.github/workflows/codeql-analysis.yml

+    paths-ignore:
+      - '**/*.md'
+      - '**/*.txt'
+      - '**/*.yaml'


Should this also include **/*.yml?

probably 😛 not sure how many we have.

aThorp96 · 2025-03-21T12:05:47Z

.github/workflows/codeql-analysis.yml

-      uses: github/codeql-action/init@v3
+      uses: github/codeql-action/init@6bb031afdd8eb862ea3fc1848194185e076637e5 # v3.28.11


🔒 🙏🏼

aThorp96 · 2025-03-21T12:43:01Z

.github/workflows/e2e-matrix.yml

+
+    - name: Run tests
+      run: |
+        ./hack/setup-kind.sh \


This script seems to exist in the plumbing repo. Any reason we wouldn't want to reference it instead of copying it?

No valid reason I can see, I just ported what we had in tektoncd/pipeline.
I would probably want to create an issue to follow-up 😛

divyansh42 · 2025-03-22T13:04:53Z

.github/workflows/ci.yaml

+        yamllint -c .yamllint $(find . -path ./vendor -prune -o -type f -regex ".*y[a]ml" -print | tr '\n' ' ')
+    - name: check-license
+      run: |
+        go install github.com/google/[email protected]


Do we have any specific reason for using 1.0.0?
I can see 1.6.0 as the latest version

Yes, after 1.0.0 a behavior breaks our usage, we had to pin this in test-runner, …

pratap0007 · 2025-03-24T14:11:06Z

/retest

pratap0007 · 2025-03-24T14:18:56Z

/lgtm

tekton-robot · 2025-03-24T14:18:59Z

@pratap0007: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vdemeester · 2025-03-24T23:53:43Z

/retest

divyansh42

/lgtm

vdemeester · 2025-03-25T12:08:06Z

/retest

pratap0007 · 2025-04-23T06:54:06Z

@piyush-garg @vinamra28 can you please review and merge this PR? Thanks!

piyush-garg · 2025-05-03T18:42:36Z

/approve

tekton-robot · 2025-05-03T18:42:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aThorp96, piyush-garg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [piyush-garg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

piyush-garg · 2025-05-04T07:03:22Z

/retest

divyansh42 · 2025-05-05T04:25:07Z

/retest

pratap0007 · 2025-05-06T13:31:00Z

/retest

waveywaves · 2025-05-14T09:25:50Z

/test pull-tekton-cli-integration-tests

vdemeester · 2025-05-14T09:42:06Z

@waveywaves @piyush-garg the prow job will always fail 😛

waveywaves · 2025-05-14T11:28:26Z

my ask for the retest was a bit mindless 😅 sorry about that

vdemeester · 2025-05-15T07:46:01Z

I can force merge, but we need to remove the prow configuration. One "problem" is that it will remove the prow check for branches : tektoncd/plumbing#2510.

We'll have to figure out what we do about bugfix releases, but I would love for this to get merged now.

afrittoli · 2025-07-16T10:24:03Z

@vdemeester What's the state of this one?

pratap0007 · 2025-07-23T09:20:20Z

@vdemeester can you please rebase it?

Importing this from the tektoncd/pipeline repsitory. Signed-off-by: Vincent Demeester <[email protected]>

… The goal is to remove the prow jobs. This is imported from tektoncd/pipeline. Signed-off-by: Vincent Demeester <[email protected]>

Let's share code 🙃. Signed-off-by: Vincent Demeester <[email protected]>

vdemeester · 2025-07-23T12:03:50Z

Rebased.

divyansh42 · 2025-07-23T14:17:30Z

@vdemeester do we want to re-run the tests?

divyansh42

/lgtm

With tektoncd/cli#2516 those are no more needed. Signed-off-by: Vincent Demeester <[email protected]>

#2560 | [dependabot[bot]] Bump github.com/go-chi/chi/v5 from 5.2.1 to 5.2.2 | 2025/07/14-12:36 #2562 | [dependabot[bot]] Bump github.com/go-viper/mapstructure/v2 from 2.2.1 to 2.3.0 | 2025/07/15-14:06 #2554 | [dependabot[bot]] Bump github.com/sigstore/sigstore from 1.9.4 to 1.9.5 | 2025/07/18-20:54 #2516 | [Vincent Demeester] .github/workflows: update codeql job | 2025/07/24-11:26 #2516 | [Vincent Demeester] .github/workflows: add slack and retest workflows | 2025/07/24-11:26 #2516 | [Vincent Demeester] .github/workflows: add a ci workflow… | 2025/07/24-11:26 #2516 | [Vincent Demeester] .github/workflows: use plumbing workflow definitions. | 2025/07/24-11:26 null | [Tyler Auerbeck] cleanup: update golangci-lint to v2 | 2025/07/28-12:33 null | [divyansh42] Fix golang CI lint failures | 2025/07/28-12:33 null | [dependabot[bot]] Bump github.com/docker/docker | 2025/08/01-09:21 null | [dependabot[bot]] Bump github.com/docker/cli | 2025/08/01-10:19 null | [dependabot[bot]] Bump github.com/tektoncd/pipeline from 1.0.0 to 1.2.0 | 2025/08/01-10:31 null | [dependabot[bot]] Bump ko-build/setup-ko from 0.8 to 0.9 | 2025/08/05-16:20 null | [dependabot[bot]] Bump github/codeql-action from 3.28.11 to 3.29.5 | 2025/08/05-16:22 null | [dependabot[bot]] Bump actions/setup-go from 5.3.0 to 5.5.0 | 2025/08/05-22:46 null | [dependabot[bot]] Bump step-security/harden-runner from 2.11.0 to 2.13.0 | 2025/08/05-22:48 null | [pratap0007] Deprecate the chain command | 2025/08/11-09:22 null | [dependabot[bot]] Bump github.com/sigstore/cosign/v2 from 2.5.0 to 2.5.3 | 2025/08/12-12:50 null | [dependabot[bot]] Bump github.com/ktr0731/go-fuzzyfinder from 0.8.0 to 0.9.0 | 2025/08/12-13:20 null | [dependabot[bot]] Bump the go-k8s-dependencies group with 3 updates | 2025/08/12-20:10 null | [dependabot[bot]] Bump github.com/spf13/pflag from 1.0.6 to 1.0.7 | 2025/08/19-02:41 null | [pratap0007] Bump tektoncd/pipeline, tektoncd/triggers and tektoncd/hub | 2025/08/19-08:11 null | [dependabot[bot]] Bump golang.org/x/term from 0.32.0 to 0.34.0 | 2025/08/19-10:45 null | [dependabot[bot]] Bump actions/checkout from 4.2.2 to 5.0.0 | 2025/08/20-08:03 null | [dependabot[bot]] Bump github/codeql-action from 3.29.7 to 3.29.10 | 2025/08/20-08:05 null | [dependabot[bot]] Bump the go-k8s-dependencies group with 3 updates | 2025/08/20-08:07 null | [huntlyroad] fix panic when trying to read pod logs when pod is already deleted | 2025/08/21-04:11 null | [divyansh42] Handle nil steps and add error message | 2025/08/21-04:11 Signed-off-by: vinamra28 <[email protected]>

tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Mar 13, 2025

tekton-robot requested review from divyansh42, piyush-garg and pradeepitm12 March 13, 2025 14:33

tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 13, 2025

vdemeester force-pushed the ci-in-workflows branch 3 times, most recently from 477255f to 7f70c7d Compare March 13, 2025 15:44

AlanGreene reviewed Mar 14, 2025

View reviewed changes

.github/workflows/chatops_retest.yaml Outdated Show resolved Hide resolved

vdemeester added a commit to vdemeester/tektoncd-plumbing that referenced this pull request Mar 17, 2025

Remove tektoncd/cli prow jobs

9260ef5

With tektoncd/cli#2516 those are no more needed. Signed-off-by: Vincent Demeester <[email protected]>

vdemeester mentioned this pull request Mar 17, 2025

Remove tektoncd/cli prow jobs tektoncd/plumbing#2510

Merged

2 tasks

vdemeester force-pushed the ci-in-workflows branch from c73cdef to 9dba98b Compare March 17, 2025 10:50

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 19, 2025

vdemeester force-pushed the ci-in-workflows branch from 9dba98b to a6d0b8e Compare March 21, 2025 11:23

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2025

aThorp96 approved these changes Mar 21, 2025

View reviewed changes

vdemeester mentioned this pull request Mar 21, 2025

Consider referencing the existing script in the plumbing repo instead of copying it #2520

Open

divyansh42 reviewed Mar 22, 2025

View reviewed changes

divyansh42 reviewed Mar 25, 2025

View reviewed changes

tekton-robot assigned divyansh42 Mar 25, 2025

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2025

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2025

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2025

vdemeester added 4 commits July 23, 2025 14:00

.github/workflows: update codeql job

3e51344

.github/workflows: add slack and retest workflows

6d654a8

Importing this from the tektoncd/pipeline repsitory. Signed-off-by: Vincent Demeester <[email protected]>

.github/workflows: add a ci workflow…

8be123c

… The goal is to remove the prow jobs. This is imported from tektoncd/pipeline. Signed-off-by: Vincent Demeester <[email protected]>

.github/workflows: use plumbing workflow definitions.

01e9e34

Let's share code 🙃. Signed-off-by: Vincent Demeester <[email protected]>

vdemeester force-pushed the ci-in-workflows branch from a6d0b8e to 01e9e34 Compare July 23, 2025 12:02

tekton-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 23, 2025

divyansh42 reviewed Jul 24, 2025

View reviewed changes

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2025

tekton-robot merged commit 2eddf32 into tektoncd:main Jul 24, 2025
21 of 22 checks passed

vdemeester deleted the ci-in-workflows branch July 24, 2025 13:52

divyansh42 mentioned this pull request Jul 28, 2025

ci: update branch protection status checks for tektoncd/cli tektoncd/plumbing#2715

Merged

2 tasks

tekton-robot pushed a commit to tektoncd/plumbing that referenced this pull request Jul 28, 2025

Remove tektoncd/cli prow jobs

70fd169

With tektoncd/cli#2516 those are no more needed. Signed-off-by: Vincent Demeester <[email protected]>

		uses: github/codeql-action/init@v3
		uses: github/codeql-action/init@6bb031afdd8eb862ea3fc1848194185e076637e5 # v3.28.11

Migrate CI into GitHub workflows #2516

Migrate CI into GitHub workflows #2516

Uh oh!

Conversation

vdemeester commented Mar 13, 2025

Changes

Submitter Checklist

Release Notes

Uh oh!

waveywaves commented Mar 13, 2025

Uh oh!

vdemeester commented Mar 13, 2025

Uh oh!

Uh oh!

vdemeester commented Mar 17, 2025

Uh oh!

vdemeester commented Mar 17, 2025

Uh oh!

aThorp96 Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

vdemeester Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

aThorp96 Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

aThorp96 Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

vdemeester Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

divyansh42 Mar 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vdemeester Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

pratap0007 commented Mar 24, 2025

Uh oh!

pratap0007 commented Mar 24, 2025

Uh oh!

tekton-robot commented Mar 24, 2025

Uh oh!

vdemeester commented Mar 24, 2025

Uh oh!

divyansh42 left a comment

Choose a reason for hiding this comment

Uh oh!

vdemeester commented Mar 25, 2025

Uh oh!

pratap0007 commented Apr 23, 2025

Uh oh!

piyush-garg commented May 3, 2025

Uh oh!

tekton-robot commented May 3, 2025

Uh oh!

piyush-garg commented May 4, 2025

Uh oh!

divyansh42 commented May 5, 2025

Uh oh!

pratap0007 commented May 6, 2025

Uh oh!

waveywaves commented May 14, 2025

Uh oh!

vdemeester commented May 14, 2025

Uh oh!

waveywaves commented May 14, 2025

Uh oh!

vdemeester commented May 15, 2025

Uh oh!

afrittoli commented Jul 16, 2025

Uh oh!

pratap0007 commented Jul 23, 2025

Uh oh!

vdemeester commented Jul 23, 2025

Uh oh!

divyansh42 commented Jul 23, 2025

divyansh42 Mar 22, 2025 •

edited

Loading