This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Repository navigation
This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Remove confusing message when attaching a debugger #767
Description
From @blagoev on February 12, 2016 12:25
This message is warning for something that may not happen depending on the actual command being used. For example the Attach debugger command (--start) will not deploy anything to the device. Now it is more visible when you try to attach since we are handling the issue that the app is not running. If we show an error message for that case it will be confusing since we stated early we will deploy something on the device which is actually not correct.
Action: Either remove this message or take into account the command executed.
Copied from original issue: NativeScript/nativescript-cli#1476
Activity
enchev commentedon Jul 22, 2016
Hey @blagoev,
What if we change the message to
Your application will work only on the device specified by the provided index or identifier.?Hey @rosen-vladimirov what do you think?
enchev commentedon Jul 22, 2016
From @blagoev on July 1, 2016 7:31
I am for just removing this message. It even does not show the selected device identifier ((we have the selected device in this._device)). It is not useful imo.
This message tries to anticipate a user confusion about something which I think is not the case.
It is even too long - nobody will read it.
A better message will be
Target device: emulator-5554 or something like that.
enchev commentedon Jul 22, 2016
Thanks @blagoev, I like that as well! Hey @rosen-vladimirov, what do you think?