This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Playground #1134
Merged
Playground #1134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
suggested changes
Sep 3, 2018
definitions/commands.d.ts
Outdated
| @@ -23,6 +23,29 @@ interface ICommand extends ICommandOptions { | |||
| postCommandAction?(args: string[]): Promise<void>; | |||
| } | |||
|
|
|||
| interface ICommandBase extends ICommand { | |||
There was a problem hiding this comment.
Can we remove this interface, we do not need it in fact
We need this in order to handle the case when `tns run --bundle` command is executed and the last connected Android device gets disconnected. In this case we need to receive DEVICE_LOST event for the android device. Currently this was impossible because all connected android devices are checked only once - at the beginning of the execution of the command.
Fatme
force-pushed
the
feature/playground
branch
from
0d504fb to
65df95e
Compare
rosen-vladimirov
approved these changes
Sep 14, 2018
Fatme
force-pushed
the
feature/playground
branch
from
ccaa281 to
f24ceea
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements: NativeScript/nativescript-cli#3813
Should be merged with this: NativeScript/nativescript-cli#3853