This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Share mobile classes and services #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ///<reference path="../.d.ts"/> | ||
| "use strict"; | ||
|
|
||
| export function isWindows() { |
There was a problem hiding this comment.
Aren't those already available in the helpers.ts?
There was a problem hiding this comment.
Yes, the goal is to remove them from helpers and use the ones in host-info. The helpers.ts becomes a monstrocity of unrelated code, imho.
|
I have a couple of ideas for refactorings but those should go in separate PRs:
|
This was referenced Aug 14, 2014
|
👍 |
Fatme
added a commit
that referenced
this pull request
Aug 19, 2014
Share mobile classes and services
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.