This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Detect unexpected emulator exit and stops waiting for it #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,6 +24,7 @@ class AndroidEmulatorServices implements Mobile.IEmulatorPlatformServices { | |||
| private static TIMEOUT_SECONDS = 120; | |||
| private static UNABLE_TO_START_EMULATOR_MESSAGE = "Cannot run your app in the native emulator. Increase the timeout of the operation with the --timeout option or try to restart your adb server with 'adb kill-server' command. Alternatively, run the Android Virtual Device manager and increase the allocated RAM for the virtual device."; | |||
| private static RUNNING_ANDROID_EMULATOR_REGEX = /^(emulator-\d+)\s+device$/; | |||
| private static EMULATOR_EXITED_MESSAGE = "The native emulator has stopped unexpectedly. Verify its configuration and try again."; | |||
There was a problem hiding this comment.
do we consider Genymotion as native emulator? The message is used for both native and Genymotion emulators
There was a problem hiding this comment.
I've modeled the message after UNABLE_TO_START_EMULATOR_MESSAGE - should we change it as well?
There was a problem hiding this comment.
I suggest to remove "native" word :)
|
The code is breaking the behavior of AppBuilder CLI where the terminal should be released when the emulator starts. Do we want this? |
|
Ignore my comment, there's another issue in AppBuilder CLI, which is causing emulator hold the console. I'll fix it in a separate PR. |
| } | ||
| emulatorProc.on("error", () => emulatorProcEnded = true); |
There was a problem hiding this comment.
You can log trace the error here
teobugslayer
force-pushed
the
totev/fix-emu-start
branch
from
d8a08aa to
e627160
Compare
|
❤️ |
teobugslayer
force-pushed
the
totev/fix-emu-start
branch
from
e627160 to
35c7757
Compare
|
❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NativeScript/nativescript-cli#645