This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Send page reload message to android runtime #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatme
force-pushed
the
fatme/page-reload
branch
3 times, most recently
from
d6f5a48 to
72c8470
Compare
| private syncCore(data: ILiveSyncData, projectFiles: string[]): IFuture<void> { | ||
| return (() => { | ||
| let platform = data.platform ? this.$mobileHelper.normalizePlatformName(data.platform) : this.$devicesService.platform; | ||
| let deviceAppData = this.$deviceAppDataFactory.create(data.appIdentifier, this.$mobileHelper.normalizePlatformName(data.platform)); |
There was a problem hiding this comment.
On the previous line, platform was set to this.$mobileHelper.normalizePlatformName(data.platform) and therefore can be used here for shorter code.
Fatme
force-pushed
the
fatme/page-reload
branch
from
31ddc26 to
d0e708c
Compare
| return (() => { | ||
| let projectFilesPath = data.localProjectRootPath || data.projectFilesPath; | ||
| let platform = data.platform ? this.$mobileHelper.normalizePlatformName(data.platform) : this.$devicesService.platform; | ||
| let deviceAppData = this.$deviceAppDataFactory.create(data.appIdentifier, this.$mobileHelper.normalizePlatformName(data.platform)); |
There was a problem hiding this comment.
Should we use platform here?
Fatme
force-pushed
the
fatme/page-reload
branch
5 times, most recently
from
9fab308 to
5d59e2b
Compare
|
❤️ |
| } | ||
|
|
||
| private getRunningSimulatorId(appIdentifier: string): string { | ||
| let iosSim = require("ios-sim-portable"); |
There was a problem hiding this comment.
can we move this to property with getter?
Fatme
force-pushed
the
fatme/page-reload
branch
from
5d59e2b to
bbbfdb6
Compare
|
❤️ |
2 similar comments
|
❤️ |
|
❤️ |
Fatme
force-pushed
the
fatme/page-reload
branch
from
cac6a77 to
505b47e
Compare
|
❤️ |
Fatme
force-pushed
the
fatme/page-reload
branch
from
505b47e to
e1b792c
Compare
|
👍 after green build |
|
❤️ |
Fatme
pushed a commit
that referenced
this pull request
Nov 12, 2015
Send page reload message to android runtime
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.