This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Wait for prepare hooks to run and collect changed files in the same livesync run #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used for extracting messages out of given .json files. If given a key be it simple (Some_error_message) or complex (iOS.iTunes.Connection_Refused_Error) should return a message if one is found in any given file. If no value is found returns the key itself. Given .json files are prioritized - that is to say if a key is found in the first file it is immediately returned. That way messages can be overriden - for example appbuilder.messages.json may override keys from common.messages.json
That way an interface (IMessages) and an implementation file is generated which can be used for autocompletion when accessing JSON-predefined error messages. Includes a bit of refactoring - extracting some classes from swagger into common. Usage of the new messages service can be seen in `devices-services` class I'm committing the first draft of messages.d.ts and messages.ts which will hopefully grow in the future.
Covering all the basic scenarios.
Get back the message that reports successful deploy on android device. We've deleted it a couple of commits ago.
Show message after successful deploy
…er-pre-150 Merge release in master pre 1.5.0
Restructure error messaging
Made Proton buildable with latest common lib
Fixed device detection in Proton
Make linter happy
Enable linter for common lib
Enable linter during Jenkins build
…150-3 Merge release in master pre 1.5.0 (third time)
This option is used by both CLI's, so add it to common options.
Conflicts: declarations.d.ts
Merge release master
Add --template option
hdeshev
force-pushed
the
hdeshev/livesync-prepare-hook-release2
branch
from
7bf114a to
40c145b
Compare
|
❤️ |
hdeshev
force-pushed
the
hdeshev/livesync-prepare-hook-release2
branch
from
40c145b to
bd93049
Compare
|
❤️ |
hdeshev
force-pushed
the
hdeshev/livesync-prepare-hook-release2
branch
from
bd93049 to
d15a090
Compare
|
❤️ |
1 similar comment
|
❤️ |
|
We are postponing this change for after 1.5.2 release to have additional time to properly test it. It is still targeting RELEASE branch though. |
|
👍 squash and merge after we release 1.5.2 |
When deploying application in Proton, Android application must be started on the device. Fix this by calling correct start method.
Start application on Android device when deploying via Proton
Fix `EPERM: operation not permitted, write` error when started from Proton installation and trying to write to stdout. The process does not have stdout, so all logger calls will cause such failure. Introduce new logger, special for Proton, that will not do anything at the moment. We'll extend it in the future to send messages to Proton with the messages.
Set version to 0.1.3
Introduce proton logger
Improve device discovery for Proton by fixing: * Crash when iPhone is not trusted. * Crash when error is raised during device detection. Currently the error is just caught, but we'll report it to Proton later. * Crash when trying to provide sysLogs for unauthorized devices. * In case more than one Android device has "USB Debugging" disabled, we were showing only one device. Show all devices from now on. Add new properties to IDeviceInfo class: * status - string, describing the status of the device, can be `Connected` or `Unauthorized`. Could be expanded in the future. * errorHelp - in case status is `Unauthorized` we provide some information to the user how to resolve the issue. In case status is `Connected` this should be null. * color - Color of the device. Not mandatory part of the Interface. Currently provided only for iOS devices. Additional changes, implementation details: Change the way we work with iOS devices - currently if the device is Unauthorized, we were just failing, without creating instance of the iOSDevice. From now on we create instance and set the values that we cannot get from the device (like Name) to null. Added ADNCI_MSG_TRUSTED=4 to iOSDeviceDiscovery. I'm not sure the value is correct, but I've received it when I select "Trust" option on iOS device. When we receive 4, we remove the old Untrusted device and add a new one with all correct properties. Keep current behavior in `AndroidDeviceDiscovery` to report device as newly attached when its status is changed.
Set version to 0.2.0
Improve device discovery and fix some issues
Fix android device detection - remove method was not correct and was never removing device. Fix ios device detection - always set status to Unreachable when there's error. Change name of Unauthorized status to Unreachable.
Set version to 0.2.1
Fix android and ios device detection
Allow for calling out to compilers in hooks and collecting changed files afterwards. Allow changes to excluded files (*.ts) to trigger a sync, and filter those files out after the platform is prepared. Fix livesync file filter bug on ios.
Mitko-Kerezov
force-pushed
the
hdeshev/livesync-prepare-hook-release2
branch
from
403e55d to
c337d26
Compare
|
❤️ |
|
Closing this and will retarget to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
afterwards.
those files out after the platform is prepared.