This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Get rid of $projectData dependency in services #900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❤️ |
1 similar comment
|
❤️ |
Mitko-Kerezov
force-pushed
the
kerezov/local-build-lib
branch
from
c2f5918 to
7fcdcb5
Compare
|
❤️ |
2 similar comments
|
❤️ |
|
❤️ |
Mitko-Kerezov
force-pushed
the
kerezov/local-build-lib
branch
from
344fabc to
b24ff20
Compare
|
❤️ |
Mitko-Kerezov
force-pushed
the
kerezov/local-build-lib
branch
from
b24ff20 to
4f89c0a
Compare
|
❤️ |
rosen-vladimirov
approved these changes
Mar 3, 2017
declarations.d.ts
Outdated
| @@ -478,6 +478,10 @@ interface ISpawnResult { | |||
|
|
|||
| interface ISpawnFromEventOptions { | |||
| throwError: boolean; | |||
| emitOptions?: { | |||
| shouldEmit: boolean; | |||
There was a problem hiding this comment.
what's the case when I pass emitOptions, but I do not want to emit?
Includes: * Split ICommonOptions interface - so that individual parts can be reused. * Allow ChildProcess to emit stdout and stderr
Mitko-Kerezov
force-pushed
the
kerezov/local-build-lib
branch
from
4f89c0a to
24d47bb
Compare
|
❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way services become stateless and can be used in long-running processes
Ping @rosen-vladimirov @TsvetanMilanov