This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Fix device log filter #905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 |
We have added one parameter in the filter method which we do not need and we do not respect it when we call the method. The solution is to remove it.
TsvetanMilanov
force-pushed
the
milanov/fix-device-log-filter
branch
from
2fcf361 to
04b0009
Compare
|
❤️ |
rosen-vladimirov
suggested changes
Mar 15, 2017
| * @param {string} pid @optional The application PID for this device. | ||
| * @param {string} logLevel @optional The logging level based on which input data will be filtered. | ||
| * @return {string} The filtered result based on the input or null when the input data shouldn't be shown. | ||
| */ | ||
| filterData(platform: string, data: string, projectDir: string, pid?: string, logLevel?: string): string; |
There was a problem hiding this comment.
This is required for NativeScript CLI:
https://github.com/NativeScript/nativescript-cli/blob/master/lib/services/ios-log-filter.ts#L11
There was a problem hiding this comment.
The projectDirectory is required only in the ios-log-filter in the NS CLI. That's why we will remove the parameter from the method and fix it only in the NS CLI.
This was referenced Mar 16, 2017
rosen-vladimirov
approved these changes
Mar 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have added one parameter in the filter method which we do not need and we do not respect it when we call the method. The solution is to remove it.