This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Fix getting info for Android tools #906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to changes in Android SDK, we have to update the checks in CLI. While gathering system information, we check the android executable, which is no longer returning correct results. In order to fix this, we rely on the emulator executable, which is the real thing we need as it is the one that allows us to work with Android Emulators. Fix sys-info checks and get correct path to emulator according to latest changes.
|
❤️ |
TsvetanMilanov
approved these changes
Mar 15, 2017
sys-info-base.ts
Outdated
| } catch (err) { | ||
| this.$logger.trace(`Error while checking is ${pathToAndroid} installed. Error is: ${err.messge}`); | ||
| this.$logger.trace(`Error while checking is emulator installed. Error is: ${err.messge}`); |
There was a problem hiding this comment.
I think we will never trace the error message from emulator -help, if there is one, because we set throwError: false on spawnFromEvent. You can check if result is false and trace the message from emulatorHelp.stdout or emulatorHelp.stderr.
AndroidEmulatorServices knows how to get information about Android Virtual Devices. Make this methods public, so they can be called from other services which need this information. Fix getting path to emulator executable on Windows - it has `.exe` and the check if it exists was always false.
|
❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changes in Android SDK, we have to update the checks in CLI. While gathering system information, we check the android executable, which is no longer returning correct results.
In order to fix this, we rely on the emulator executable, which is the real thing we need as it is the one that allows us to work with Android Emulators.
Fix sys-info checks and get correct path to emulator according to latest changes.