This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Add check in iOS device discovery if platform is Android. #985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 |
KristianDD
force-pushed
the
kddimitrov/fix-itunes-android-check
branch
from
4302fcf to
c36888c
Compare
|
💔 |
KristianDD
force-pushed
the
kddimitrov/fix-itunes-android-check
branch
from
c36888c to
1a769e9
Compare
|
💔 |
KristianDD
force-pushed
the
kddimitrov/fix-itunes-android-check
branch
from
1a769e9 to
592dbeb
Compare
|
💔 |
rosen-vladimirov
suggested changes
Jul 10, 2017
|
💔 |
rosen-vladimirov
previously approved these changes
Jul 11, 2017
KristianDD
force-pushed
the
kddimitrov/fix-itunes-android-check
branch
from
ef32193 to
e7c411d
Compare
|
💔 |
KristianDD
force-pushed
the
kddimitrov/fix-itunes-android-check
branch
from
e7c411d to
b6cf2c2
Compare
|
💔 |
KristianDD
force-pushed
the
kddimitrov/fix-itunes-android-check
branch
from
b6cf2c2 to
95849d8
Compare
|
💔 |
rosen-vladimirov
approved these changes
Jul 13, 2017
|
💔 |
KristianDD
force-pushed
the
kddimitrov/fix-itunes-android-check
branch
from
a0c0992 to
78e73ee
Compare
|
💔 |
KristianDD
force-pushed
the
kddimitrov/fix-itunes-android-check
branch
from
78e73ee to
9f5a60e
Compare
|
💔 |
rosen-vladimirov
approved these changes
Jul 19, 2017
|
Recomendation: Because these options: |
|
💔 |
Plamen5kov
approved these changes
Jul 20, 2017
KristianDD
force-pushed
the
kddimitrov/fix-itunes-android-check
branch
from
3e8d759 to
0e58f9e
Compare
|
💔 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the resolution of NativeScript/nativescript-cli#2361.
The device discovery services didn't check the platform parameter before performing the validations needed for the specified platform.
The resolution is to always pass platform parameter to the device discovery services if specified and add a platform check inside each device discovery service.