This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Return the real transferred files when transferDirectory of device fs is called #992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 |
nadyaA
approved these changes
Jul 26, 2017
| @@ -102,28 +102,27 @@ export class AndroidDeviceFileSystem implements Mobile.IDeviceFileSystem { | |||
|
|
|||
| let deviceHashService = this.getDeviceHashService(deviceAppData.appIdentifier); | |||
| let filesToChmodOnDevice: string[] = devicePaths; | |||
| if (this.$options.force) { | |||
| let tranferredFiles: Mobile.ILocalToDevicePathData[] = []; | |||
| let oldShasums = await deviceHashService.getShasumsFromDevice(); | |||
| } else { | ||
| await this.adb.executeCommand(["push", projectFilesPath, await deviceAppData.getDeviceProjectRootPath()]); | ||
| } | ||
| let changedShasums: any = _.omitBy(currentShasums, (hash: string, pathToFile: string) => !!_.find(oldShasums, (oldHash: string, oldPath: string) => pathToFile === oldPath && hash === oldHash)); |
rosen-vladimirov
force-pushed
the
vladimirov/fix-livesync-after-uninstall
branch
from
09330ac to
fa6e6f2
Compare
|
💔 |
… is called When uploading files on devices/emulators, we are executing either `transferDirectory` or `transferFiles` methods of the specific device instance. However for Android devices, the transferDirectory method has some logic to transfer only modified files (based on shasums from previous execution). So it doesn't really transfer the directory, but just several files. For LiveSync purposes it is important to know which are the tranferred files, so change the return type of `transferDirectory` method to return the exact files that we've sent to device. Try-catch the stop of iOS Application as it may fail in some rare cases - in this case just retry it.
rosen-vladimirov
force-pushed
the
vladimirov/fix-livesync-after-uninstall
branch
from
fa6e6f2 to
e0f0174
Compare
|
💔 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When uploading files on devices/emulators, we are executing either
transferDirectoryortransferFilesmethods of the specific device instance.However for Android devices, the transferDirectory method has some logic to transfer only modified files (based on shasums from previous execution). So it doesn't really transfer the directory, but just several files.
For LiveSync purposes it is important to know which are the tranferred files, so change the return type of
transferDirectorymethod to return the exact files that we've sent to device.Try-catch the stop of iOS Application as it may fail in some rare cases - in this case just retry it.