Skip to content

Conversation

@spkane31
Copy link
Contributor

adding a timestamp to TriggerImmediatelyRequest message

We can make the wft “more idempotent”: put the desired trigger time in the trigger immediately request itself, so it goes in the signal payload, so all wfts attempt to start the target with the same id.

Covered by existing functional tests

Potential risks

@spkane31 spkane31 requested review from a team as code owners June 25, 2025 15:27
@CLAassistant
Copy link

CLAassistant commented Jun 25, 2025

CLA assistant check
All committers have signed the CLA.

@yuandrew
Copy link
Contributor

We don't need to manually pull in updates from the api repo, we have a GH action that runs when updates are merged to main that will automatically update api-go https://github.com/temporalio/api/actions/workflows/trigger-api-go-update.yml

@spkane31 spkane31 closed this Jun 25, 2025
@spkane31 spkane31 deleted the spk/trigger-immediately-bug branch June 25, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants