Remove buf breaking exception #609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnr
approved these changes
Jul 7, 2025
| ignore: | ||
| # TODO (yuri) remove this. Added for "heartbeat" change (add | ||
| - temporal/api/workflowservice/v1/request_response.proto |
Contributor
There was a problem hiding this comment.
we could leave one commented out so it's clear to the next person that this should contain a filename and what the filename should be relative to
Sushisource
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
remove exception for "workflowservice/v1/request_response.proto"
Why?
This file is important, I don't want to hide it from this check for a long time.