Add more operator cluster commands #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Feb 16, 2024
Member
cretz
left a comment
cretz
left a comment
There was a problem hiding this comment.
Ug, sorry you had to dig up this stuff. At least you know more about cluster stuff now, heh.
|
|
||
| var nextPageToken []byte | ||
| var execsProcessed int | ||
| for pageIndex := 0; ; pageIndex++ { |
Member
There was a problem hiding this comment.
This is one of those cases I wonder if we never expect a large list and therefore should just collect the list and dump all at once. Regardless, I added to #448 to revisit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
operator cluster list,operator cluster upsertandoperator cluster remove.To write the tests I had to expose a bunch of cluster configs in the Test server and make sure the test could actually read them to use and verify the information.