Replace release workflow with goreleaser from main #510
Conversation
josh-berry
left a comment
josh-berry
left a comment
There was a problem hiding this comment.
lgtm, just a couple dumb questions.
| - 'v[0-9]+.[0-9]+.[0-9]+' | ||
| - '**' |
There was a problem hiding this comment.
If this is a regex, shouldn't it be .*?
There was a problem hiding this comment.
The doc train I followed from https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#running-your-workflow-only-when-a-push-of-specific-tags-occurs -> https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore -> https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet made me assume it's their own format
| uses: goreleaser/goreleaser-action@v5 | ||
| uses: goreleaser/goreleaser-action@336e29918d653399e599bfca99fadc1d7ffbc9f7 # v4.3.0 |
There was a problem hiding this comment.
Any reason not to use v5 of goreleaser? (I feel like we should probably just bite the bullet and pull all the updates / work out all the kinks in the release process now with the RC but that's not a strong opinion)
There was a problem hiding this comment.
I just copied main to keep it safe to run as main runs. I don't even like the file name much less the contents. We should revisit this (and include docker publish), but I want initial release to get done.
What was changed
Replace release GH workflow with goreleaser from main so that it will run on release and can be manually triggered. I suspect once cli-rewrite is on main we may make the name more generic to support things like docker publish