Update next-server branch with main changes #792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) <!--- Note to EXTERNAL Contributors --> <!-- Thanks for opening a PR! If it is a significant code change, please **make sure there is an open issue** for this. We work best with you when we have accepted the idea first before you code. --> <!--- For ALL Contributors 👇 --> ## What was changed <!-- Describe what has changed in this PR --> Add extended info to the DescribeWorkflow output. ## Why? <!-- Tell your future self why have you made these changes --> Customer request.
…-with-start` commands (temporalio#762) added `temporal workflow start-update-with-start` and `temporal workflow execute-update-with-start` commands `temporal workflow start-update-with-start` usage: ``` temporal workflow start-update-with-start \ --update-name YourUpdate \ --update-input '{"update-key": "update-value"}' \ --update-wait-for-stage accepted \ --workflow-id YourWorkflowId \ --type YourWorkflowType \ --task-queue YourTaskQueue \ --id-conflict-policy Fail \ --input '{"wf-key": "wf-value"}' ``` `temporal workflow execute-update-with-start` usage: ``` temporal workflow execute-update-with-start \ --update-name YourUpdate \ --update-input '{"update-key": "update-value"}' \ --workflow-id YourWorkflowId \ --type YourWorkflowType \ --task-queue YourTaskQueue \ --id-conflict-policy Fail \ --input '{"wf-key": "wf-value"}' ``` 1. Closes temporalio#664 2. How was this tested: <!--- Please describe how you tested your changes/how we can test them --> 3. Any docs updates needed? Yes
## What was changed quote attribute type in error message ## Why? To make whitespace more obvious --------- Co-authored-by: Rodrigo Zhou <[email protected]>
<!--- Note to EXTERNAL Contributors --> <!-- Thanks for opening a PR! If it is a significant code change, please **make sure there is an open issue** for this. We work best with you when we have accepted the idea first before you code. --> <!--- For ALL Contributors 👇 --> ## What was changed <!-- Describe what has changed in this PR --> Check if extended info is not nil. ## Why? <!-- Tell your future self why have you made these changes --> temporalio#771 Code assumes that some extended info exists in proto. Which is not true for older server versions..
## What was changed <!-- Describe what has changed in this PR --> Pinned v1.34.1 for modernc/sqlite ## Why? <!-- Tell your future self why have you made these changes --> 1.34.2 has a regression, waiting on https://gitlab.com/cznic/sqlite/-/issues/196 to be resolved. See temporalio/temporal#7333 for more details ## Checklist <!--- add/delete as needed ---> 1. Closes temporalio#777 2. How was this tested: <!--- Please describe how you tested your changes/how we can test them --> 3. Any docs updates needed? <!--- update README if applicable or point out where to update docs.temporal.io -->
## What was changed
<!-- Describe what has changed in this PR -->
Added a tags section to match what Documentation side has
## Why?
<!-- Tell your future self why have you made these changes -->
We previously just used keywords, but that could be seen as keyword
stuffing. The tags were updated on the docs side a few months ago,
changes were never updated on this side.
## Checklist
<!--- add/delete as needed --->
1. Closes <!-- add issue number here -->
2. How was this tested:
<!--- Please describe how you tested your changes/how we can test them
-->
3. Any docs updates needed?
<!--- update README if applicable
or point out where to update docs.temporal.io -->
---------
Co-authored-by: Chad Retz <[email protected]>
cretz
approved these changes
Apr 17, 2025
Member
cretz
left a comment
cretz
left a comment
There was a problem hiding this comment.
I assume there were no surprising conflicts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Update next-server branch with main changes