Add VISIBILITY_POSTGRES_USER and VISIBILITY_POSTGRES_PWD #292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
It is possible to use two separate database names: one for "core" and one for "visibility" database. By default, the same user/password was used for both databases.
This change adds two new env variables that can be used to provide user/pass for "visibility" database.
Small fix applied: use
-pwparameter instead of exportedSQL_PASSWORDenv variable.Why?
Checklist
Closes [Feature Request] Add VISIBILITY_POSTGRES_USER/PWD parameters to auto-setup.sh #291
How was this tested:
I checked out https://github.com/temporalio/docker-compose
I used modified docker-compose file:
postgres initdb script (to create test users):
Started the stack using docker compose and checked the logs, database contents.
probably https://docs.temporal.io/self-hosted-guide/visibility#postgresql
Maybe example docker-compose should be added to https://github.com/temporalio/docker-compose