Drop dockerize to mitigate writes to filesystem. #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was initiated from deploying into OpenShift which randomizes the uid/gid when launching a pod
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Removed dockerize from images. This appears to have been planned, but I didn't see any PRs related.
Why?
Best practice to avoid writing to the filesystem in addition to allowing images to be deployed to openshift.
For more info - #241
Checklist
Closes [Feature Request] Support for OpenShift ui#2327, [Feature Request] Support for OpenShift #241
How was this tested:
I tested by deploying with the helm charts to OCP.
Any docs updates needed?
Don't believe so... I was initially looking at putting in a conditional for what temporal-server tag was being built to determine whether dockerize was needed given older versions don't contain sprig to read in the docker.yaml template, but noticed within 1.29 release 'BREAKING CHANGES' comment so figured 'yolo'.