Skip to content

Conversation

@aarohib
Copy link
Contributor

@aarohib aarohib commented May 9, 2023

What does this PR do?

Notes to reviewers

Thank you for taking the time to review this PR!

  • All files under the docs folder are generated guides and not specific to the updates made in this PR. You can skip reviewing them.
  • Changed files that need a review in this PR are under docs-src/clusters, docs-src/concepts, docs-src/references, and kb.
  • concepts/what-is-cluster-security-configuration and concepts/what-is-cluster-obervability are just new files that rehome currently published content and were created to reorganize the Cluster concept so the info flows better. Changes in these files are not a priority in this update (but I'm happy to make any pressing updates to incorrect info).

@aarohib
Copy link
Contributor Author

aarohib commented Jun 14, 2023

@dnr and @yycptt
Since this is a long thread and missing comments is easier than finding them, here is a list of comment threads that I need responses on:

Copy link
Contributor

@dnr dnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dynamic config stuff looks good to me

Copy link
Member

@yycptt yycptt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, configuration part looks good!

Copy link
Contributor

@djmagee djmagee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three nits, and this is good to go!

Copy link
Contributor

@flossypurse flossypurse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @aarohib !

@aarohib aarohib merged commit 924378c into main Jun 15, 2023
@aarohib aarohib deleted the AB/ClusterConfigUpdates branch June 15, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants