Skip to content

Assume TLS enabled if API key provided in SDKs #687

@cretz

Description

@cretz

Describe the solution you'd like

We already do this for env config and for CLI. This 💥 technically-backwards-incompatible change is to change SDKs to assume if an API key is provided, that TLS is enabled unless explicitly set otherwise. Some SDKs this can be done more easily than others (e.g. Go may need a TLSDisabled field).

This is a backwards incompatible change, but only for self-hosting users with no TLS but still using relatively-recent API key SDK functionality. This is likely rare or doesn't happen at all (though it may in proxy scenarios), but needs to be clearly called out in release notes with explainer on how to re-disable TLS.

Per-SDK Tickets

  • Go - TODO
  • Java - TODO
  • Core - N/A
  • TypeScript - TODO
  • Python - TODO
  • .NET - TODO
  • Ruby - TODO
  • PHP - TODO
  • Temporal CLI - Done

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions