Update Go to 1.37 #697
Open
Update Go to 1.37 #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Nov 12, 2025
Sushisource
force-pushed
the
fix-deployment-tests
branch
5 times, most recently
from
22ba464 to
4b43987
Compare
Sushisource
force-pushed
the
fix-deployment-tests
branch
from
4b43987 to
52b65e4
Compare
carlydf
reviewed
Nov 20, 2025
| Namespace: ns, | ||
| DeploymentName: deploymentName, | ||
| Version: "__unversioned__", | ||
| BuildId: "__unversioned__", |
There was a problem hiding this comment.
try with empty string here. If Build ID and deprecated Version are both present, server uses BuildId, but if only Version is present, server uses Version stirng
There was a problem hiding this comment.
for "unset" ramping version the "old" way, you'll need to do
Version: "",
BuildId: "",
for "unset" current version the "old" way, you'll need to do
Version: "__unversioned__",
BuildId: "",
Signed-off-by: Spencer Judge <[email protected]>
Sushisource
force-pushed
the
fix-deployment-tests
branch
from
52b65e4 to
94efa47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.