DEVPROD-628 Add option to disable default search attributes #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
dandavison
reviewed
Nov 20, 2024
loadgen/scenario.go
Outdated
| // by the run, they must be registerd by some other method. This is needed because cloud cells | ||
| // cannot use the SDK to register SAs, instead the SAs must be registered through the control plane. | ||
| // Default is false. | ||
| NoDefaultSearchAttributes bool |
Contributor
There was a problem hiding this comment.
How about DoNotRegisterSearchAttributes and --do-not-register-search-attributes?
I'm thinking that's slightly more accurate / precise, since an attempt will be made to use the default search attributes regardless of the value of this option; we're controlling whether they should be registered.
Contributor
Author
There was a problem hiding this comment.
Good call. Changed
lilydoar
force-pushed
the
DEVPROD-628
branch
2 times, most recently
from
dbcc436 to
efcfb03
Compare
lilydoar
force-pushed
the
DEVPROD-628
branch
from
efcfb03 to
36b28d3
Compare
dandavison
reviewed
Nov 20, 2024
Co-authored-by: Dan Davison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added an option to disable creating the default search attributes
Why?
Scenarios running against cloud server cells cannot create search attributes through the SDK. They must use the control plane instead.