Kitchensink test #180

stephanos · 2025-07-29T23:22:31Z

What was changed

Framework for checking kitchensink actions across SDKs.

(more tests to be added later ...)

Why?

To ensure actions are supported correctly and comprehensively; and document missing implementations.

Especially for new actions this helps ensure you've implemented them correctly.

Checklist

Closes
How was this tested:

Any docs updates needed?

## What was changed  Move code to build and start worker from `main` into `workers` package. No behavior change expected. ## Why?  Reusability. The [kitchensink parity test](#180) needs to start workers for testing. ## Checklist  1. Closes  2. How was this tested:  3. Any docs updates needed?

stephanos · 2025-08-05T23:07:08Z

workers/run.go

-	scenarioName := r.ScenarioID.Scenario()
-	scenario := loadgen.GetScenario(scenarioName)
-	if scenario == nil {
-		return fmt.Errorf("scenario %v not found", scenarioName)
-	}


Not needed; already done by caller.

stephanos · 2025-08-05T23:07:25Z

scripts/install-dotnet.sh


 echo "Installing .NET $DOTNET_VERSION..."
-mise use dotnet-core@"$DOTNET_VERSION"
+mise use dotnet@"$DOTNET_VERSION"


core was not sufficient, actually.

stephanos · 2025-08-05T23:07:59Z

cmd/run_worker.go

 func (r *workerRunner) preRun() {
 	r.builder.preRun()
 	r.Runner.Builder = r.builder.Builder
+	r.TaskQueueName = loadgen.TaskQueueForRun(r.ScenarioID.Scenario, r.ScenarioID.RunID)


Moved here to avoid circular dependency on loadgen.

stephanos · 2025-08-05T23:08:15Z

cmd/cmdoptions/scenario.go

+	Scenario string
+	RunID    string


Simpler than the getters, actually.

stephanos · 2025-08-05T23:08:32Z

cmd/build_worker_image.go

 		args = append(args, "--build-arg", arg)
 	}
-	args = append(args, rootDir())
+	args = append(args, repoDir())


I think repo is clearer than root.

stephanos · 2025-08-05T23:08:48Z

workers/typescript/src/workflows/kitchen_sink.ts

      throw new ApplicationFailure('ExecuteNexusOperation is not supported');
    } else {
-      throw new ApplicationFailure('Unknown action ' + JSON.stringify(action));
+      throw new ApplicationFailure('unrecognized action ' + JSON.stringify(action));


The other SDKs all call it that.

stephanos · 2025-08-05T23:09:54Z

workers/build.go

+func BaseDir(repoDir string, lang cmdoptions.Language) string {
+	return filepath.Join(repoDir, "workers", lang.String())
+}


Made reusable.

PS: Can't hide this detail since the caller often wants to cleanup this dir; if we hide it internally, they don't know what to cleanup.

stephanos · 2025-08-06T17:22:29Z

.github/workflows/ci.yml

          severity: error

-  build-lint-test-go:
+  test-omes:


Added this since the CI wasn't actually running the Omes tests themselves.

Sushisource

Dude this is slick. I saw the history matching thing at first and alarm bells went off but when I saw what it was, it's cool. A lot like some of the tests in Core.

Sushisource · 2025-08-06T22:35:08Z

.github/workflows/docker-images.yml

        if: ${{ !inputs.do-push || github.event.pull_request.head.repo.fork }}
        with:
-          go-version: '^1.24'
+          go-version-file: 'go.mod'


Whaaaat you can do that?

Sushisource · 2025-08-06T22:43:34Z

loadgen/helper_historyrequire.go

+	Fields  map[string]any
+}
+
+func requireHistoryMatches(t *testing.T, actualEvents []*historypb.HistoryEvent, expectedSpec string) {


Doc of the expected spec would be very welcome here. I was worried at first this was a much tighter match than it actually is.

Good call! 👍 The whole thing is inspired by Alex's version in OSS Server, but much much shorter (partly thanks to Claude).

alexshtin · 2025-08-07T04:32:03Z

loadgen/kitchen_sink_executor_test.go

+				WorkflowExecutionStarted
+				WorkflowTaskScheduled
+				WorkflowTaskStarted
+				WorkflowTaskCompleted
+				TimerStarted {"startToFireTimeout":"0.001s"}
+				TimerFired
+				WorkflowTaskScheduled
+				WorkflowTaskStarted
+				WorkflowTaskCompleted
+				WorkflowExecutionCompleted`,


Server has printHistory helper func to print history in this format. You might want it here too.

stephanos mentioned this pull request Jul 31, 2025

Re-usable Worker build and start #184

Merged

stephanos force-pushed the kitchensink-validation branch 2 times, most recently from cd53095 to 1215eaa Compare August 1, 2025 19:48

stephanos changed the title ~~Kitchensink parity test~~ Kitchensink test Aug 5, 2025

stephanos force-pushed the kitchensink-validation branch 3 times, most recently from d83fd6a to 838e3c1 Compare August 5, 2025 23:06

stephanos commented Aug 5, 2025

View reviewed changes

stephanos force-pushed the kitchensink-validation branch from 838e3c1 to b8e75e3 Compare August 5, 2025 23:09

stephanos commented Aug 5, 2025

View reviewed changes

stephanos force-pushed the kitchensink-validation branch 10 times, most recently from 5eac796 to a9c0069 Compare August 6, 2025 00:20

stephanos closed this Aug 6, 2025

stephanos force-pushed the kitchensink-validation branch from a9c0069 to aa6de40 Compare August 6, 2025 00:26

stephanos reopened this Aug 6, 2025

stephanos force-pushed the kitchensink-validation branch from c76810a to f635e08 Compare August 6, 2025 00:29

stephanos force-pushed the kitchensink-validation branch 15 times, most recently from 2a22bc0 to 6d3cb6c Compare August 6, 2025 17:21

stephanos commented Aug 6, 2025

View reviewed changes

stephanos force-pushed the kitchensink-validation branch 2 times, most recently from 6699ae9 to a7be1b2 Compare August 6, 2025 17:39

stephanos marked this pull request as ready for review August 6, 2025 17:47

stephanos requested a review from Sushisource August 6, 2025 17:47

kitchensink test

f8a4d45

stephanos force-pushed the kitchensink-validation branch from a7be1b2 to f8a4d45 Compare August 6, 2025 22:43

Sushisource approved these changes Aug 6, 2025

View reviewed changes

add comment

eeb920e

stephanos force-pushed the kitchensink-validation branch from b177b99 to eeb920e Compare August 6, 2025 23:30

stephanos closed this Aug 7, 2025

stephanos reopened this Aug 7, 2025

alexshtin approved these changes Aug 7, 2025

View reviewed changes

stephanos merged commit 784fcda into main Aug 7, 2025
64 checks passed

stephanos deleted the kitchensink-validation branch August 7, 2025 16:42

Kitchensink test #180

Kitchensink test #180

Uh oh!

Conversation

stephanos commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What was changed

Why?

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stephanos Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stephanos Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sushisource left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

stephanos commented Jul 29, 2025 •

edited

Loading

stephanos Aug 5, 2025 •

edited

Loading

stephanos Aug 5, 2025 •

edited

Loading