Scenario validation #185
Merged
Scenario validation #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
commented
Aug 1, 2025
Comment on lines
+149
to
+151
| if v == "" { | ||
| return defaultValue | ||
| } |
Sushisource
approved these changes
Aug 4, 2025
loadgen/scenario.go
Outdated
| // | ||
| // Call this method if you want to ensure that all required configuration parameters | ||
| // are present and valid without actually running the executor. | ||
| Parse(ScenarioInfo) error |
Member
There was a problem hiding this comment.
Technically not really parsing - could just call this Configure ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added new
Configurableinterface for a scenario to opt-in to. It exposes a method parse the scenario input.Why?
In a CICD context it's helpful to validate if a scenario is correctly configured before starting it since any issues would only be surfaced once the infra is all setup (time consuming and expensive).
Checklist
Closes
How was this tested: