Fix throughput_stress resume #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
commented
Sep 4, 2025
| // each iteration. | ||
| UpdateWorkflowOptions func(context.Context, *Run, *KitchenSinkWorkflowOptions) error | ||
|
|
||
| DefaultConfiguration RunConfiguration |
Collaborator
Author
There was a problem hiding this comment.
Leftover from last PR where I removed it.
stephanos
commented
Sep 4, 2025
| } | ||
|
|
||
| // Initial check before entering the loop. | ||
| if err := check(); err != nil { |
Collaborator
Author
There was a problem hiding this comment.
Minor optimization to query immediately instead of waiting for first tick.
stephanos
commented
Sep 4, 2025
| startTime := time.Now() | ||
| iterStart := time.Now() | ||
|
|
||
| defer func() { |
Collaborator
Author
There was a problem hiding this comment.
Main fix: by using defer, we now guarantee it always records the completion.
stephanos
commented
Sep 4, 2025
| go func() { | ||
| var err error | ||
| startTime := time.Now() | ||
| iterStart := time.Now() |
Collaborator
Author
There was a problem hiding this comment.
Address variable shadowing.
stephanos
force-pushed
the
fix-resume-tps
branch
from
9c9e0f4 to
6a689f5
Compare
stephanos
force-pushed
the
fix-resume-tps
branch
from
6a689f5 to
be115a8
Compare
stephanos
commented
Sep 4, 2025
| }, | ||
| } | ||
| workerDone <- runner.Run(t.Context(), baseDir) | ||
| workerDone <- runner.Run(ctx, baseDir) |
Collaborator
Author
There was a problem hiding this comment.
Cancellation was never reaching worker ...
stephanos
commented
Sep 4, 2025
|
|
||
| env := workers.SetupTestEnvironment(t, | ||
| workers.WithExecutorTimeout(2*time.Minute), | ||
| workers.WithExecutorTimeout(1*time.Minute), |
Collaborator
Author
There was a problem hiding this comment.
With proper worker shutdown (see below), test is much faster now.
Sushisource
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Fix resume bug.
Why?
The
OnCompletehook wasn't always invoked properly leading to under-counting the completed iterations.Checklist
Closes
How was this tested: