Add option to ignore already started error #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
commented
Oct 9, 2025
|
|
||
| // When resuming, it can happen that the workflow for the current iteration already exists since the snapshot | ||
| // was not up-to-date. In that case, we just skip this iteration and move on. | ||
| info.Configuration.HandleExecuteError = func(ctx context.Context, run *loadgen.Run, err error) error { |
Collaborator
Author
There was a problem hiding this comment.
This was the only use case for HandleExecuteError; we could consider removing it entirely until there's a use case again?
Sushisource
reviewed
Oct 14, 2025
| scenarioOptions []string | ||
| timeout time.Duration | ||
| doNotRegisterSearchAttributes bool | ||
| ignoreAlreadyStarted bool |
Member
There was a problem hiding this comment.
Where does this actually get read?
Collaborator
Author
There was a problem hiding this comment.
Yup, that part somehow got lost. Added!
Sushisource
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
WISOTT
Why?
When running a scenario it can happen that transient failures lead to an incomplete scenario run and on retry the scenario will then fail because workflows were already created. It's not always possible here to use a new/clean task queue; in those cases, this new flag allows to skip over these errors.
Checklist
Closes
How was this tested: