Wait for ExecuteChildWorkflowAction to complete by default #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephan Behnke <[email protected]>
THardy98
approved these changes
Nov 18, 2025
Contributor
THardy98
left a comment
THardy98
left a comment
There was a problem hiding this comment.
LGTM - just unsure of why the one change is necessary
| Input: []*common.Payload{ | ||
| ConvertToPayload(&WorkflowInput{ | ||
| InitialActions: ListActionSet(NewTimerAction(1 * time.Millisecond)), | ||
| InitialActions: ListActionSet(NewEmptyReturnResultAction()), |
Collaborator
Author
There was a problem hiding this comment.
Without a ReturnResult action the workflow never returns. That's why it had the abandon policy on it before.
Error: Received unexpected error:
timed out while waiting for runs to complete: context deadline exceeded
Test: TestKitchenSink/ExecActivity/ExecChildWorkflow/go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Make .NET, Python and TS kitchensink workflows wait for child workflow execution completion.
Go and Java already do the right thing.
Why?
The default wait
AwaitableChoicepolicy iswaitFinish, but these impls only wait for the start, not completion.Checklist
Closes
How was this tested: