add wait command #263
Open
add wait command #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
We could also allow the embedded server to stay alive. This would allow us to query it after the execution of a load test during development. |
Member
|
I'm fine with this if we can't do it otherwise, but, seemingly there must be a way to simply configure k8s to... not restart the container if it exits with a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add a global flag called
--waitthat will wait indefinitely after any command is executedWhy?
When running omes in a Kubernetes environment, it executes a load test on container startup and then exits immediately. Upon exit, Kubernetes restarts the pod, causing the load test to run again. This creates an endless cycle of load tests without a clean way to stop load test execution.
The
--waitflag addresses this by allowing omes to wait indefinitely after completing its work (or doing nothing at all), keeping the container alive. This enables:--waitin addition other argument to running one-time load tests--waitas a default arg in the deployment, allowing the pod to start idle and wait for an engineer to update the deployment with the desired load test configuration.