Skip to content

Fix race in memberlist.MakeChange #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Fix race in memberlist.MakeChange #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions swim/memberlist.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ import (

"github.com/benbjohnson/clock"
"github.com/dgryski/go-farm"
"github.com/uber-common/bark"
"github.com/temporalio/ringpop-go/logging"
"github.com/temporalio/ringpop-go/util"
"github.com/uber-common/bark"
)

// A memberlist contains the membership for a node
Expand Down Expand Up @@ -486,12 +486,13 @@ func (m *memberlist) Evict(address string) {
// makes a change to the member list
func (m *memberlist) MakeChange(address string, incarnation int64, status string) []Change {

member, _ := m.Member(address)

// create the new change based on information know to the memberlist
var change Change
m.members.RLock()
member := m.members.byAddress[address]
change.populateSubject(member)
change.populateSource(m.local)
m.members.RUnlock()

// Override values that are specific to the change we are making
change.Address = address
Expand Down