-
Notifications
You must be signed in to change notification settings - Fork 11
feature: pass ww PID to the PHP workers #705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Valery Piashchynski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds workflow worker PID tracking to prevent sending responses from dead workers, and includes minor comment improvements. The changes help ensure that messages are tagged with the correct worker PID to handle worker lifecycle scenarios more gracefully.
Key Changes
- Added a
WorkflowWorkerPIDfield to theMessagestructure with JSON serialization support - Updated
PushCommandandAllocateMessagemethods to accept and set the workflow worker PID - Fixed minor grammatical issues in code comments
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/protocol.go | Added WorkflowWorkerPID field to the Message struct for tracking worker identity |
| queue/queue.go | Updated queue methods to accept and populate the workflow worker PID parameter |
| queue/queue_test.go | Updated test to pass the new required PID parameter to PushCommand |
| aggregatedpool/workflow.go | Added logic to retrieve and pass workflow worker PID when pushing commands; fixed comment grammar |
| aggregatedpool/handler.go | Added workflow worker PID retrieval logic across multiple handler methods |
| aggregatedpool/workers.go | Fixed extra whitespace in comment |
| go.work.sum | Updated dependency checksums |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Valery Piashchynski <[email protected]>
Signed-off-by: Valery Piashchynski <[email protected]>
Signed-off-by: Valery Piashchynski <[email protected]>
Signed-off-by: Valery Piashchynski <[email protected]>
Signed-off-by: Valery Piashchynski <[email protected]>
Reason for This PR
Description of Changes
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).CHANGELOG.md.