-
Notifications
You must be signed in to change notification settings - Fork 11
feature: acceptance tests #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
roxblnfk
wants to merge
10
commits into
temporalio:master
Choose a base branch
from
roxblnfk:acceptance-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
39f6bb3
chore: add php-sdk submodule for acceptance tests
roxblnfk bd58b85
ci: add acceptance tests workflow with PHP SDK
roxblnfk 1811ba0
ci: enable submodule checkout in Linux CI workflow
roxblnfk 4324054
ci: Configure RR builder for acceptance tests
roxblnfk 9b105cc
chore: Hardcode velox and RR versions on building
roxblnfk 63de213
ci: add GITHUB_TOKEN environment variable for RoadRunner build
roxblnfk de37515
ci: add GITHUB_TOKEN environment variable for downloading binaries
roxblnfk 356ac47
chore: Update PHP SDK submodule
roxblnfk d8b031c
chore: Add memory plugin to dload.xml
roxblnfk 2dd5bde
docs: Add README for acceptance tests setup and usage
roxblnfk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| [submodule "tests/acceptance/php-sdk"] | ||
| path = tests/acceptance/php-sdk | ||
| url = [email protected]:temporalio/sdk-php.git |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| ## Acceptance Tests | ||
|
|
||
| This directory contains acceptance tests to verify the functionality of RoadRunner and PHP SDK integration with Temporal server. | ||
| The PHP SDK is included as a submodule in this repository. | ||
|
|
||
| ### Setup | ||
|
|
||
| To run the PHP SDK, you need to install Composer dependencies: | ||
|
|
||
| ```bash | ||
| cd tests/acceptance/php-sdk | ||
| composer update | ||
| ``` | ||
|
|
||
| Next, you need to download the Temporal Dev Server and Temporal Test Server. | ||
| This is done using the DLoad utility, which comes bundled with the PHP SDK. | ||
| DLoad automatically fetches the correct binary versions from the configuration, which is especially useful since different PHP SDK branches may require different Temporal server versions (including pre-release builds with experimental features). | ||
|
|
||
| Download the binaries with: | ||
|
|
||
| ```bash | ||
| cd tests/acceptance/php-sdk | ||
| vendor/bin/dload get temporal temporal-tests-server | ||
| ``` | ||
|
|
||
| To build RoadRunner with the Temporal plugin, we also use DLoad. It fetches the plugin version numbers from build.roadrunner.dev, generates the Velox configuration, and runs Velox to build RoadRunner with the current codebase. | ||
|
|
||
| ```bash | ||
| cd tests/acceptance | ||
| php-sdk/vendor/bin/dload build | ||
| ``` | ||
|
|
||
| ### Running Tests | ||
|
|
||
| Navigate to the php-sdk directory and run the Acceptance or Functional tests using Composer: | ||
|
|
||
| ```bash | ||
| cd tests/acceptance/php-sdk | ||
| composer test:acc | ||
| composer test:func | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <?xml version="1.0"?> | ||
rustatian marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <dload xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:noNamespaceSchemaLocation="https://raw.githubusercontent.com/php-internal/dload/refs/heads/1.x/dload.xsd" | ||
| temp-dir="./runtime" | ||
| > | ||
| <actions> | ||
| <download software="velox" /> | ||
| <velox config-file="./velox.toml" | ||
| velox-version="2025.1.4" | ||
| roadrunner-ref="v2025.1.4" | ||
| binary-path="./php-sdk/rr" | ||
| > | ||
| <plugin name="temporal" replace="../.."/> | ||
| <plugin name="rpc"/> | ||
| <plugin name="kv"/> | ||
| <plugin name="memory"/> | ||
| <plugin name="server"/> | ||
| <plugin name="logger"/> | ||
| <plugin name="appLogger"/> | ||
| <plugin name="status"/> | ||
| </velox> | ||
| </actions> | ||
| </dload> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| [log] | ||
| level = "debug" | ||
| mode = "production" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.