feature: roadrunner-temporal v6 — connect-rpc control plane

[rustatian]

v6 line of the plugin, tracking the RoadRunner v6 plugin set.

• module moved to github.com/temporalio/roadrunner-temporal/v6
• control RPC migrated from goridge net/rpc to Connect-RPC: RPC() (string, http.Handler) returns the generated TemporalService handler; soft errors keep v5 parity by reporting through common.v1.Status in the response
• logging migrated from zap to log/slog to match the v6 plugin set (endure wires interfaces structurally; the Temporal SDK logger now goes through log.NewStructuredLogger)
• deps: roadrunner-server/api/v4 → api-go/v6 + api-plugins/v6, pool → pool/v2, goridge dropped
• integration tests run against the v6 plugin set; helpers ported to the Connect clients (Go-SDK worker against temporal server start-dev)
• CI coverage paths updated to the /v6 module

Known red until the PHP worker speaks Connect: the PHP→RR reverse RPC path (e.g. temporal.RecordActivityHeartbeat on :6001) — the heartbeat tests in general/tls fail on it (now gracefully instead of panicking).

Note: api-go/v6 is pinned to a pseudo-version until roadrunner-server/api#75 and roadrunner-server/api-go#21 merge and a new beta tag is cut.

[Copilot]

Pull request overview

This PR ports roadrunner-temporal to the v6 line (module path + dependency set) and migrates the plugin control plane from Goridge net/rpc to Connect-RPC, updating the plugin’s exported RPC surface and the integration tests accordingly.

Changes:

• Migrate control RPC implementation to Connect-RPC handlers (Plugin.RPC() (string, http.Handler) + generated TemporalService handler).
• Port integration tests from Goridge net/rpc clients to Connect-RPC clients (plus shared Connect test helpers).
• Update module path to /v6 and refresh RoadRunner/Temporal-related dependencies to their v6/v2 lines.

Reviewed changes

Copilot reviewed 32 out of 34 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/updates/updates_replay_test.go	Switch replay/download test calls from Goridge net/rpc to Connect-RPC client calls.
tests/tls/hp_tls_test.go	Port TLS suite’s activity/workflow name fetching to Connect-RPC.
tests/tls/disaster_tls_test.go	Replace informer/resetter Goridge calls with Connect-RPC helper calls.
tests/helpers/rpc.go	Add Connect-RPC helper clients for Temporal/Informer/Resetter services used by tests.
tests/helpers/helpers.go	Update test helper imports to /v6 module path + v6 dataconverter.
tests/go.mod	Update test module deps to api-go/v6, Connect, and v6 plugin module path replacement.
tests/go.sum	Dependency checksum updates for Connect + v6 RoadRunner APIs.
tests/general/rpc_test.go	Port RPC methods test to Connect-RPC calls and v6 API protos.
tests/general/plugin_status_test.go	Update import to /v6 module path.
tests/general/hp_test.go	Port activity/workflow name fetching to Connect-RPC.
tests/general/general_test.go	Replace Goridge informer calls with Connect-RPC helper calls.
tests/general/disaster_test.go	Replace informer/resetter Goridge calls with Connect-RPC helper calls.
status.go	Update imports for RoadRunner pool v2 + api-plugins v6 status types.
rpc.go	Implement Connect-RPC TemporalService handler methods and soft-status responses.
queue/queue.go	Update internal import path to /v6.
queue/queue_test.go	Update internal import path to /v6.
plugin.go	Change exported RPC() to return Connect handler + update pool/process imports for v6/v2 deps.
metrics.go	Update pool imports to v2.
internal/codec/proto/proto.go	Update temporal protocol import to api-go/v6 and pool payload import to v2.
internal.go	Update pool/static pool imports to v2 and module imports to /v6.
info.go	Update goridge frame import to v4 and pool payload import to v2.
config.go	Update pool import to v2.
api/interfaces.go	Update pool/payload/worker/process imports to v2 and module imports to /v6.
aggregatedpool/workflow.go	Update payload import to v2 and module imports to /v6.
aggregatedpool/workers.go	Update module imports to /v6.
aggregatedpool/workers_test.go	Update module imports to /v6.
aggregatedpool/local_activity.go	Update goridge frame import to v4, payload import to v2, module imports to /v6.
aggregatedpool/interceptor.go	Update module import to /v6.
aggregatedpool/handler.go	Update goridge frame import to v4, payload import to v2, module imports to /v6.
aggregatedpool/activity.go	Update goridge frame import to v4, payload import to v2, module imports to /v6.
go.mod	Change module path to /v6 and add/update v6/v2 dependencies including Connect.
go.sum	Dependency checksum updates for Connect + v6/v2 RoadRunner deps.
go.work	Bump workspace Go version patch.
go.work.sum	Workspace checksum updates including Connect.

Comments suppressed due to low confidence (1)

rpc.go:131

• ReplayWorkflow starts its history fetch with context.Background(), which drops the Connect handler's cancellation/deadline. This can cause unnecessary work if the client disconnects or times out. Use the handler context as the parent for the timeout context (and avoid the unused _ context.Context parameter).

func (r *rpc) ReplayWorkflow(_ context.Context, req *connect.Request[protoApi.ReplayRequest]) (*connect.Response[protoApi.ReplayResponse], error) {
	in := req.Msg
	out := &protoApi.ReplayResponse{}

	r.plugin.log.Debug("replay workflow request",
		zap.String("run_id", in.GetWorkflowExecution().GetRunId()),
		zap.String("workflow_id", in.GetWorkflowExecution().GetWorkflowId()),
		zap.String("workflow_name", in.GetWorkflowType().GetName()))

	if in.GetWorkflowExecution() == nil || in.GetWorkflowType() == nil ||
		in.GetWorkflowExecution().GetRunId() == "" || in.GetWorkflowExecution().GetWorkflowId() == "" || in.GetWorkflowType().GetName() == "" {
		out.Status = newStatus(codes.InvalidArgument, "run_id, workflow_id or workflow_name should not be empty")

		r.plugin.log.Error("replay workflow request", zap.String("error", "run_id, workflow_id or workflow_name should not be empty"))
		return connect.NewResponse(out), nil
	}

	ctx, cancel := context.WithTimeout(context.Background(), time.Minute)
	defer cancel()
	iter := r.plugin.temporal.client.GetWorkflowHistory(ctx, in.GetWorkflowExecution().GetWorkflowId(), in.GetWorkflowExecution().GetRunId(), false, enums.HISTORY_EVENT_FILTER_TYPE_ALL_EVENT)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[rustatian]

Closing: the Connect-RPC control plane is being reverted org-wide. feature/v6 now carries the v6 work with the control plane back on goridge net/rpc; a fresh v6 PR will follow once the reverted dependencies are tagged.