generate operator client and create new routing client #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pglass
reviewed
Mar 26, 2025
| request *adminservice.AddSearchAttributesRequest, | ||
| opts ...grpc.CallOption, | ||
| ) (*adminservice.AddSearchAttributesResponse, error) { | ||
| return c.adminClient.AddSearchAttributes(ctx, request, opts...) |
Contributor
There was a problem hiding this comment.
I think this return is unintentional?
Contributor
|
I think this makes sense. Thanks! I did a basic test with TCP mode and this Temporal PR: temporalio/temporal#7446
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Point AdminService to OperatorService in a handful of deprecated routes.
Why?
To remove references to deprecated routes in AdminService
Checklist
IDK, need help from CGS.
Closes OSS-4102
How was this tested:
Has not been, still needs to be.
Any docs updates needed?
Need input from CGS