Skip to content

Support translating cluster name #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Support translating cluster name #88

wants to merge 9 commits into from

Conversation

@pglass
Copy link
Contributor

@pglass pglass commented Jun 4, 2025

What was changed

  • Add clusterNameTranslation field to the config file (same format as namespaceNameTranslation)
  • Add visitClusterName reflection function to translate cluster name, and bit of code deduplication

Why?

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@pglass pglass requested a review from hehaifengcn June 4, 2025 19:09
@pglass pglass requested a review from a team as a code owner June 4, 2025 19:09
Base automatically changed from pglass/translation-refactor to main June 13, 2025 19:20
@pglass pglass marked this pull request as draft August 19, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hehaifengcn hehaifengcn Awaiting requested review from hehaifengcn

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pglass