Demonstrate interoperability with Coinbase Ruby SDK #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
commented
Feb 4, 2025
cretz
commented
Feb 4, 2025
Gemfile
Outdated
|
|
||
| # Additional dependencies for certain samples | ||
| gem 'google-protobuf', '~> 3.25' | ||
| gem 'temporal-ruby', path: '../coinbase-temporal-ruby' |
Member
Author
There was a problem hiding this comment.
Point to GitHub repo when coinbase/temporal-ruby#335 merged (or consider pointing to fork temporarily)
Member
Author
There was a problem hiding this comment.
We're leaving the fork reference for now
mjameswh
reviewed
Feb 6, 2025
| @@ -0,0 +1,24 @@ | |||
| # Coinbase Ruby | |||
|
|
|||
| This sample shows a workflow, activity, and client from [Coinbase Ruby SDK](https://github.com/coinbase/temporal-ruby) | |||
There was a problem hiding this comment.
This sample shows a workflow, activity, and client from Coinbase Ruby SDK able to interoperate with a workflow, activity, and client from Temporal Ruby SDK
Maybe that's just me, but the "… able to …" in the middle reads badly.
Member
Author
There was a problem hiding this comment.
I think "This sample shows [X] able to interoperate with [Y]" reads ok
mjameswh
reviewed
Feb 6, 2025
mjameswh
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added sample and test to show how Coinbase SDK activities, workflows, and clients interoperate with the Temporal SDK equivalents. Requires the following two PRs from other projects before it will pass CI:
But it can still be reviewed even without CI passing