Handle errors with update result serialization #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
commented
Apr 28, 2025
| return task.ContinueWith( | ||
| _ => | ||
| { | ||
| inProgressHandlers.Remove(inProgress); |
Member
Author
There was a problem hiding this comment.
The PR makes this a bit ugly, I recommend "hide whitespace" in the this diff view (i.e. https://github.com/temporalio/sdk-dotnet/pull/468/files?diff=unified&w=1)
cretz
commented
Apr 28, 2025
| public Task RunAsync() => Workflow.WaitConditionAsync(() => false); | ||
|
|
||
| [WorkflowSignal] | ||
| [WorkflowUpdate] |
Member
Author
There was a problem hiding this comment.
This is to fix a mostly-unrelated flake where slow GH runners were not guaranteeing signal order as the test expected
Sushisource
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Previously we swallowed failures to serialize update results. Now we will fail the update or the task depending on the error.
Checklist