NewNonRetryableApplicationError not respected by

[moh-abk]

Expected Behavior

Regardless of what is set in temporal.RetryPolicy, NewNonRetryableApplicationError should not be retried

Actual Behavior

NewNonRetryableApplicationError returned by activities are still being retried.

Steps to Reproduce the Problem

1. Create a workflow with RetryPolicy: &temporal.RetryPolicy{}
2. Create an activity that returns temporal.NewNonRetryableApplicationError
3. Execute the workflow

Specifications

• Version: v0.26.0

[moh-abk]

After much investigation it seems adding an error (cause) to NewNonRetryableApplicationError (https://github.com/temporalio/temporal-go-sdk/blob/master/error.go#L165) - is what is causing the issue

to get the desired outcome I had to do this;

temporal.NewNonRetryableApplicationError("random string", nil, "random string")

passing an error like below doesn’t work;

temporal.NewNonRetryableApplicationError("random string", err, "random string")

forked repo here - https://github.com/moh-abk/temporal-go-samples/tree/non-retry-testing