Skip to content

Manually copy proxy options #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Manually copy proxy options #1502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion client/service_proxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,10 @@ type WorkflowServiceProxyOptions struct {
// be forwarded to the passed in WorkflowService Client. GRPC interceptors can be added on the Server or Client to adjust
// requests and responses.
func NewWorkflowServiceProxyServer(options WorkflowServiceProxyOptions) (workflowservice.WorkflowServiceServer, error) {
return proxy.NewWorkflowServiceProxyServer(proxy.WorkflowServiceProxyOptions(options))
return proxy.NewWorkflowServiceProxyServer(proxy.WorkflowServiceProxyOptions{
// These options are expected to be kept mostly in sync, but we can't do a
// naive type conversion because we want users to be able to update to newer
// API library versions with older SDK versions.
Client: options.Client,
})
}